Repository navigation
[Feat] beam: support LoRA for BF16 and FP8 - #48264
Merged
Merged
Conversation
jybsuper
force-pushed
the
yanbin/beam-lora-main
branch
from
November 3, 2026 23:13
387b871 to
fd9a341
Compare
jybsuper
force-pushed
the
yanbin/beam-lora-main
branch
from
November 4, 2026 01:28
fd9a341 to
ecc3b1b
Compare
jybsuper
marked this pull request as ready for review
November 4, 2026 01:41
jybsuper
requested review from
Alisehen,
AniZpZ,
BBuf,
Edwardf0t1,
FlamingoPg,
Fridge003,
HaiShaw,
OrangeRedeng,
Ying1123,
b8zhong,
ch-wan,
lifuhuang and
yushengsu-thu
as code owners
November 4, 2026 01:41
Limit non-shared dense MLP buffers to layers with matching linears while preserving PP-local and shared-expert allocation. Fix subtest assertion scope and cover the Beam channel/token FP8 recipe.
jybsuper
force-pushed
the
yanbin/beam-lora-main
branch
from
November 4, 2026 01:46
ecc3b1b to
50be687
Compare
Fridge003
approved these changes
Nov 6, 2026
frrad
pushed a commit
to modal-projects/sglang
that referenced
this pull request
Nov 10, 2026
Copy the applicable upstream implementations and regression bodies from sgl-project/sglang commit 1ecf89b. Only recontextualize hunks around the existing Spindle fork code. Pool API adaptations, fork-specific behavior, and additional regressions follow in a separate commit.
frrad
pushed a commit
to modal-projects/sglang
that referenced
this pull request
Nov 16, 2026
Copy the applicable upstream implementations and regression bodies from sgl-project/sglang commit 1ecf89b. Only recontextualize hunks around the existing Spindle fork code. Pool API adaptations, fork-specific behavior, and additional regressions follow in a separate commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enable Beam LoRA serving for BF16 and compressed-tensors FP8 checkpoints with the
csgmv/tritonLoRA backends and theauto/tritonMoE runner.Modifications
self_attn.gate_projas an explicit attention target; baregate_projcontinues to target MLP/MoE projections. Qualified attention-gate discovery also applies to other models exposing that module name.Accuracy Tests
Manual validation on the initial port,
ef6c8bcafb, before the final allocation/test follow-up:reflection/Beam-1.0-501B-A23B-FP8on GB300, TP4, Triton, dynamic rank-4 adapterso_proj-only and all-target adapters changed first-token logprobsThe full-checkpoint smoke used synthetic adapters and establishes loading/serving behavior, not model quality or merged-weight FP8 equivalence. Graph capture completed; replay was not explicitly logged. The temporary tiny-model fixtures/E2E scripts are not included in this PR.
For the final follow-up,
fd9a341598, local source-isolated CPU checks passed 8 allocation cases and 2 loading/clearing probes; the pre-fix allocator failed the intended sparse-layer regression. These checks use production method bodies with real CPU tensors and isolated import/module boundaries. Full unit collection was blocked by missing local_lzma/Triton dependencies; this final revision has not been rerun on GPUs.Speed Tests and Profiling
No throughput benchmark. Dense-buffer allocation is reduced without changing inference computation.
Checklist
git diff --checkpass.pre-commit run --all-files; the remaining failure is existing Linux-only Rust APIs unavailable on macOS.CI States
Latest PR Test (Base): ✅ Run #41756297099
Latest PR Test (Extra): ❌ Run #41756297324
Latest PR Test (AMD ROCm 10): ❌ Run #41756297075
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: